Elevate warnigns to errors on gcc and clang #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elevate warnigns to error on gcc and clang. This sets our error level pretty high. CI will be an important part of this strategy working.
|
OK so @defiantnerd this makes the vst3 wrapper use all the warnings on mac and linux. I think we should turn this on but it will mean broken CI sometimes since they warnings differ by platform. If you are comfy with that I am also. But I can see wanting to wait. It would close #81 if we did it though, or at least close that then encourage someone to do same for MSVC. |
defiantnerd
pushed a commit
that referenced
this pull request
Sep 9, 2023
Elevate warnigns to error on gcc and clang. This sets our error level pretty high. CI will be an important part of this strategy working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elevate warnigns to error on gcc and clang.
This sets our error level pretty high. CI will be an important part of this strategy working.